Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling: Missing indentions for level5 and deeper #3800

Closed
mrimann opened this issue Mar 6, 2013 · 3 comments
Closed

Styling: Missing indentions for level5 and deeper #3800

mrimann opened this issue Mar 6, 2013 · 3 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mrimann
Copy link

mrimann commented Mar 6, 2013

Piwik v1.9.2

When visiting the list of pages for a certain range, the pages are shown as a hierarchical tree with some indention per level.

Now with a page that has deep-nested pages, this works fine for the first 4 levels - but starting from the 5th level, the deeper level is shown with the same indention as the one above (and not further indented as expected).

This makes reading/browsing in this list really complicated.

In the CSS, there are definitions like the following for the levels 1 to 4:

tr.level4 td.label {
    padding-left: 5em;
}

Please add additional definitions like above for the levels 5 and deeper.

Keywords: indention css

@mattab
Copy link
Member

mattab commented Mar 11, 2013

I remember I did this on purpose to avoid high levels to have too much padding. please submit pull request if you find a good solution (eg. only add padding if there is enough space available)

@mrimann
Copy link
Author

mrimann commented Mar 12, 2013

I think it shouldn't be a big issue to add padding to the levels 5 to 8 IMHO: The tree is shown collapsed. And the padding is only visible, as soon as the user opens a nested section.

Right now, the way it's shown is close to unusable. So I'm in favor of adding the padding. I think only the smallest part of the user base will ever see it - and they'll be able to handle it (and be happy about it!). For everyone else, nothing changes.

One idea could be, to reduce the amount of padding form 5em to e.g. 4em (untested), so that the indention is reduced a bit - allowing for more indention steps in the deeper levels.

@mattab
Copy link
Member

mattab commented Feb 6, 2014

In bcf3847: Fixes #3800 Adding indentation up to level 12, thanks for the suggestion!

@mrimann mrimann added this to the 2.x - The Great Piwik 2.x Backlog milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants