Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibreJS compatibility for piwik.js: free/libre license notice #3770

Closed
anonymous-matomo-user opened this issue Feb 21, 2013 · 6 comments
Closed

LibreJS compatibility for piwik.js: free/libre license notice #3770

anonymous-matomo-user opened this issue Feb 21, 2013 · 6 comments
Assignees
@mattab
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
2.4.0

Comments

@anonymous-matomo-user
Copy link

LibreJS is a browser plugin that was created by the free software community to alert the user when a site serving JavaScript does not respect user's freedom. piwik.js is an example of a JavaScript file which causes LibreJS plugin to complain because piwik.js does not meet its criteria. To make sure that piwik.js meets these criteria, all that is needed is to add the license notice in the proper format at the beginning of the file. Instructions on how to do so are available here:

https://www.gnu.org/software/librejs/free-your-javascript.html

I am intending to submit a pull request in the near future that remedies this issue.
Keywords: librejs
@mattab
Copy link
Member

mattab commented Feb 22, 2013

Sounds good! but please keep it as simple as possible

@robocoder
Copy link
Contributor

I support the idea, but disagree with the implementation. The @license and @link annotations are already well-established conventions, machine-readable, and compact.

@mattab
Copy link
Member

mattab commented Feb 22, 2013

I see the point of having "new" tags since this enforces a review of the implementation. For example, one file could have Doc at the top but contain non enforced libs appended at the end. However the diff is ridiculously long, of course we are never going to do that.

Please submit a 1 line diff and then we can consider. feel free to suggest to FSF if it's not possible yet according the librejs spec, I'm sure they will happily listen to feedback. Thanks!

@robocoder
Copy link
Contributor

The librejs spec offers an alternative for webmasters: web labels. It requires an external file (which lists JavaScript files used by the site in a table with links to the license text instead of the license text itself).

@mattab
Copy link
Member

mattab commented Jun 10, 2014

In 6656833: Adding LibreJS license information in piwik.js Fixes #3770 #5276
https://www.gnu.org/software/librejs/free-your-javascript.html#magnet-link-license

@mattab
Copy link
Member

mattab commented Jun 10, 2014

See: #5276 Piwik to become an official GNU Package

@anonymous-matomo-user anonymous-matomo-user added this to the 2.4.0 - Piwik 2.4.0 milestone Jul 8, 2014
@mattab mattab mentioned this issue Jun 18, 2014
Closed
9 tasks
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
3 participants
@mattab @robocoder @anonymous-matomo-user