@xjpvictor opened this Issue on January 23rd 2013

SEO widget is not showing domain age with the following settings:

  1. piwik is installed with a sub-domain, (eg. abc.xxx.com)
  2. curl is used
  3. open_basedir is set

It seems that sendHttpRequestBy in core/Http.php is not handling the redirection header when open_basedir is set and curl is used.

@robocoder commented on January 29th 2013 Contributor

Yes, as the commented code states, when open_basedir is set, curl_setopt(CURLOPT_FOLLOWLOCATION) fails with php 5.2+.

Per Matt's comment in r7010, let's refactor core/Http.php into smaller subclasses (e.g., Stream, Socket, Curl). There would need to be some rework to detect the "best" method at runtime.

@mattab commented on February 6th 2014 Member

I definitely still think it should be refactored, but for simplicity let's close the ticket, as there would be more refactor tickets to create. Refactoring rocks! https://en.wikipedia.org/wiki/Code_refactoring

This Issue was closed on February 6th 2014
Powered by GitHub Issue Mirror