Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins API: Allow disable row evolution row action for #3650

Closed
anonymous-matomo-user opened this issue Jan 3, 2013 · 1 comment
Closed

Plugins API: Allow disable row evolution row action for #3650

anonymous-matomo-user opened this issue Jan 3, 2013 · 1 comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. worksforme The issue cannot be reproduced and things work as intended.
Milestone
1.12

Comments

@anonymous-matomo-user
Copy link

I've built one custom report, want to show the evolution statistics, in the code file "/plugins/API/API.php", I've changed it as below:

if
(
    $apiModule != 'Actions'
    &&
    ($apiModule != 'Goals' || ($apiAction != 'getVisitsUntilConversion' && $apiAction != 'getDaysToConversion'))
    && $label // do not request processed metrics when retrieving top n labels
)

to

if
(
    ($apiModule != 'Actions' && $apiModule != 'CustomReports') // Custom Report is being excluded
    &&
    ($apiModule != 'Goals' || ($apiAction != 'getVisitsUntilConversion' && $apiAction != 'getDaysToConversion'))
    && $label // do not request processed metrics when retrieving top n labels
)

So my question should be: can "$apiModule != 'CustomReports'" be something else that the developer can customize or do any settings without touching it (Core or core plugins)?

Thanks.
@mattab
Copy link
Member

mattab commented Jan 18, 2013

Why exactly did you change this? what was the problem before exactly with your custom reports?

yes we would like to solve this problem to let plugins do what they need without touching core but I'd need to know the use case.

@anonymous-matomo-user anonymous-matomo-user added this to the 1.12 - The Great 1.x Backlog milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Milestone
1.12
Development

No branches or pull requests
2 participants
@mattab @anonymous-matomo-user