We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When I am using the python script to import the iis log, the error message will show up as below:
Strict Notice: Only variables should be passed by reference in D:\Web\PHP\Piwik\core\Common.php on line 105
The text was updated successfully, but these errors were encountered:
Change
return str_replace($prefixTable, '', $table, $count = 1);
to
$count = 1; return str_replace($prefixTable, '', $table, $count);
Sorry, something went wrong.
(In [7710]) Fixes #3641 Thanks for the patch mihui!
Should we globally stop using this form of method parameter documentation?
If yes, I suggest this form (or some variant):
return str_replace( $prefixTable, '', $table, 1 // count );
Replying to JulienM:
Should we globally stop using this form of method parameter documentation? If yes, I suggest this form (or some variant): return str_replace( $prefixTable, '', $table, 1 // count );
Not sure, you might be right for the form, but you must put variable there. :)
Replying to mihui:
Have a look at the complete function code. This variable is not used elsewhere.
Replying to mihui: Not sure, you might be right for the form, but you must put variable there. :) Have a look at the complete function code. This variable is not used elsewhere.
Yeah, you are right. :), just not sure why they put it there. But you can't just put a CONST there since it is using the reference of a variable.
No branches or pull requests
When I am using the python script to import the iis log, the error message will show up as below:
The text was updated successfully, but these errors were encountered: