@anonymous-matomo-user opened this Issue on November 3rd 2012

Bug in 'Visitor Overview'.
Steps to reproduce:

  1. Disable Plugin 'Goals'
  2. Show 'Visitors' > 'Overview'
  3. Click on Icon 'Metrics to plot' (positioned after title 'Evolution over the period')

Item 'nb_visits_converted' is shown (but has no data).

Hint to source correction:
dont fill 'nb_visits_converted' into $selectableColumns in plugins\VisitSummary\Controller.php without checking the plugin in lines 59-75.

Lousy example to patch:

$selectableColumns = array(
    // columns from VisitsSummary.get
$displaygoals = Piwik_PluginsManager::getInstance()->isPluginActivated('Goals');
if($displaygoals) {
    $selectableColumns[] = 'nb_visits_converted';
// columns from Actions.get
$selectableColumns[] ='nb_pageviews';
$selectableColumns[] ='nb_uniq_pageviews';
$selectableColumns[] ='nb_downloads';
$selectableColumns[] ='nb_uniq_downloads';
$selectableColumns[] ='nb_outlinks';
$selectableColumns[] ='nb_uniq_outlinks';

$idSite = Piwik_Common::getRequestVar('idSite');

Keywords: VisitSummary nb_visits_converted Goals

@mattab commented on November 3rd 2012 Member

Thanks for the report. Are you using Piwik with goals plugin disabled? Have you found other problems ?

@anonymous-matomo-user commented on November 4th 2012

There are two installations. The tracking code points to the first installation, plugins enabled/disabled as usual (from default installation). The second installation takes its data from the same database, but noone is tracking and only a few plugins (Actions, Dashboard, Login, VisitSummary, Widgetize) are enabled.

For the second installation I dont care about any problems outside the visitors overview page. Because the installed version is not up to date (1.8.4), I also cannot really tell you if disabling the goals plugin works in general.

But i've made some short tests this morning.

  1. a new local installation (Version 1.9.1), plugin goals disabled, then data generated by plugin VisitorGenerator. Bad idea. Most widgets show nothing. It seems like it is not advisable to disable goals.
  2. The other way: new local installation (Version 1.9.1), data generated by plugin VisitorGenerator, then plugin goals disabled.

I've seen the following problems:

  • widget 'visits over time' tries to show 'Visits with Conversions'
  • widget 'Visits by Server Time' tries to show 'Conversions'.
  • widget 'Visits overview (with graph)' tries to show 'Visits with Conversions'

But don't waste too much time on this if it gets too complicated. I'm aware of the rare occasions of installations with disabled goals plugin.

@mattab commented on November 6th 2012 Member

visitor generator requires all plugins enabled

This Issue was closed on November 6th 2012
Powered by GitHub Issue Mirror