Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow evolution graph - Improve loading time to enable graphs in Piwik Mobile #3464

Closed
tsteur opened this issue Oct 21, 2012 · 6 comments
Closed
Labels
c: Performance For when we could improve the performance / speed of Matomo. worksforme The issue cannot be reproduced and things work as intended.

Comments

@tsteur
Copy link
Member

tsteur commented Oct 21, 2012

Loading an evolution graph takes a very long time. Sometimes > 1 Minute. In comparison a normal graph takes only 1 or 2 seconds.

We should profile what takes that long and optimize this. For example the queries which are performed while creating the graph.

Evolution Graph should also load in 1-3 seconds if possible. Otherwise it takes too long to display the graph in Piwik Mobile since it also takes some time to download the graph (depending on the current Internet connection on the mobile device)

@mattab
Copy link
Member

mattab commented Oct 22, 2012

A bug caused by slow Row Evolution was reported in #3363

@mattab
Copy link
Member

mattab commented Oct 27, 2012

See also #3465 to do at same time

As related to #3464, @capedfuzz would you be interested in profiling with xhprof and seeing if we could quick-fix this slowness? let's not spend more than 3 hours on this, but hopefully in this short time we can find a solution to make Static Historical Graph super fast.

This would be a big plus for PIwik Mobile, which could then start using these graphs (they are disabled until they can be made faster). Thanks!

@mattab
Copy link
Member

mattab commented Dec 17, 2012

For example this graphs URL takes 3-4 seconds to generate but ideally should take 1 second max (if possible).

@diosmosis
Copy link
Member

Optimization Idea: DataTableManipulator loads subtables one at a time. It's possible to load them all at once however (which is done when expanded=1), then access the DataTable in DataTable_Manager. Since manipulators are run after the main request though, we'll want to make sure we're not accessing the subtables twice (otherwise memory consumption will go up).

@mattab
Copy link
Member

mattab commented Feb 1, 2014

btw is this still a problem ? Or are graphs loading OK on the mobile app now?

@tsteur tsteur added this to the 2.x - The Great Piwik 2.x Backlog milestone Jul 8, 2014
@mattab mattab removed the P: normal label Aug 3, 2014
@mattab mattab modified the milestones: Mid term, Long term Oct 11, 2014
@mattab mattab modified the milestones: Mid term, Long term Jun 12, 2015
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
@tsteur tsteur added worksforme The issue cannot be reproduced and things work as intended. and removed Lower priority Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Performance For when we could improve the performance / speed of Matomo. labels Jan 16, 2018
@tsteur
Copy link
Member Author

tsteur commented Jan 16, 2018

I think this issue can be closed. feel free to reopen if still a problem

@tsteur tsteur closed this as completed Jan 16, 2018
@tsteur tsteur added the c: Performance For when we could improve the performance / speed of Matomo. label Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Performance For when we could improve the performance / speed of Matomo. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Development

No branches or pull requests

3 participants