@craue opened this Pull Request on July 5th 2014 Contributor

This gives me a more useful error log entry

<pre>ERROR Piwik\Tracker[2014-07-05 12:03:10] [33868] Got invalid response from API request: https://127.0.0.1/piwik/index.php?module=API&amp;method=API.getDefaultMetricTranslations&amp;format=original&amp;serialize=1&amp;trigger=archivephp. Response was &<a href='/039'>#039</a>;Got invalid response from API request: https://127.0.0.1/piwik/index.php?module=API&amp;method=API.getDefaultMetricTranslations&amp;format=original&amp;serialize=1&amp;trigger=archivephp. Response was &<a href='/039'>#039</a>;curl_exec: SSL certificate problem, verify that the CA cert is OK. Details: error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed. Hostname requested was: 127.0.0.1&<a href='/039'>#039</a>;&<a href='/039'>#039</a>;</pre>

instead of

<pre>ERROR Piwik\Tracker[2014-07-05 12:02:06] [03840] Got invalid response from API request: https://127.0.0.1/piwik/index.php?module=API&amp;method=API.getDefaultMetricTranslations&amp;format=original&amp;serialize=1&amp;trigger=archivephp. Response was &<a href='/039'>#039</a>;Got invalid response from API request: https://127.0.0.1/piwik/index.php?module=API&amp;method=API.getDefaultMetricTranslations&amp;format=original&amp;serialize=1&amp;trigger=archivephp. The response was empty. This usually means a server error. This solution to this error is generally to increase the value of &<a href='/039'>#039</a>;memory_limit&<a href='/039'>#039</a>; in your php.ini file. Please check your Web server Error Log file for more details.&<a href='/039'>#039</a>;</pre>

because in case of an exception in Http::sendHttpRequestBy, $response is undefined and always empty.

Maybe the entire branch for that dummy message could be removed. Let me know what you think or if I missed something here.

@mattab commented on July 7th 2014 Member

Cheers, that small change will help in many cases!

This Pull Request was closed on July 7th 2014
Powered by GitHub Issue Mirror