Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overlap code in core/Tracker/Visit.php #3400

Closed
anonymous-matomo-user opened this issue Sep 20, 2012 · 1 comment
Closed

overlap code in core/Tracker/Visit.php #3400

anonymous-matomo-user opened this issue Sep 20, 2012 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@anonymous-matomo-user
Copy link

The function call
$isLastActionInTheSameVisit = $this->isLastActionInTheSameVisit();
(https://github.com/piwik/piwik/blob/master/core/Tracker/Visit.php#L199)

Is not necessary because we already have $timeLookBack criteria in recognizeTheVisitor() function. So we can't find any result that isn't in the same visit.
@mattab
Copy link
Member

mattab commented Sep 21, 2012

If you have a patch please update, otherwise I'm sorry I have a list of about 100 items that could be done...

@mattab mattab added the wontfix label Aug 3, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattab @anonymous-matomo-user