New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposition of new hook in FrontController #339

Closed

mgazdzik wants to merge 1 commit into matomo-org:master from mgazdzik:frontControllerHook

Contributor

mgazdzik commented Jul 2, 2014

hook is triggered only after somebody has been authenticated


          proposition of new hook in FrontController

f86dbaf

Member

mattab commented Jul 3, 2014

hooks should not be within if statements (hooks should have no logic specifically for them). In this case the listener could test if user is anonymous.
I don't think this hook is necessary, because there is Request.dispatch triggered at almost same code path: http://developer.piwik.org/api-reference/events#apirequestdispatch

mattab closed this

mattab added this to the 2.5.0 - Piwik 2.5.0 milestone

mattab added R: wontfix and removed R: wontfix labels

mattab added the R: worksforme label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment