Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets use the same evolution graph having the same id, causing widgets to not display #3388

Closed
mattab opened this issue Sep 19, 2012 · 8 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Sep 19, 2012

It was reported in the forums that widgets might not all work with IE9. Let's try and reproduce and fix this error as suggested in the forum: http://forum.piwik.org/read.php?2,81831,page=1#msg-93868

@sgiehl
Copy link
Member

sgiehl commented Sep 24, 2012

If 'Visits over time' and 'Visits overview (with graph)' widgets are on the same dashboard there occurs an js-error in ie 9 and the widgets aren't displayed correct

@sgiehl
Copy link
Member

sgiehl commented Sep 25, 2012

the problem seems to be that both widgets uses the same evolution graph having the same id. that results in an js error in jqplot. the error is reproducable in all browsers.

@mattab
Copy link
Member Author

mattab commented Sep 28, 2012

What do you think about adding the name of the controller action in the unique ID string to prevent having same IDs for different widgets?

@diosmosis
Copy link
Member

In 56ff24c: Fixes #3388, added DataTableManager JS class used to initialize and set element ID for all DataTable in browser, instead of using report as element ID.

@diosmosis
Copy link
Member

In 2bb94ce: Refs #3388, fix regression in visitor log and remove use of window.dataTables in favor of jQuery.data.

@diosmosis
Copy link
Member

In 492c651: Refs #3388, fix regression in initial load of evolution graphs.

@diosmosis
Copy link
Member

In 9e112cd: Refs #3388, fix another regression that affects row evolution popups w/ external series toggle.

@diosmosis
Copy link
Member

In 1149f26: Refs #3388, fix subtable loading regression and add docs explaining how id is set to datatable.js.

@mattab mattab added this to the 1.12 - The Great 1.x Backlog milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

3 participants