Custom Logo and reverse proxy with patch #3318
Comments
|
Attachment: Custom logo - Reverse proxy issue - Patch |
|
Absolute URLs are required for HTML reports where the base tag is not used (due to poor email client support). I'm surprised it works with PDF reports. Does it still work if you save the report to your desktop, and then open it locally? Returning a path when the $pathOnly == false is contrary to the intent of that API method. So, this isn't the right fix either way. This scenario requires that we revisit #2501 which was also proxy related. |
|
Sorry guys, I did some more testing but wanted to investigate further before replying. Yes it does work for PDF saved locally opened with Evince. HTML report received in Icedove are indeed missing the custom logo. r4946 linked doesn't seems to be proxy related. Probably several commits were used to solve #2501 |
|
wont apply this patch, please reopen if you have working patch, thanks |
|
We are facing the same problem with piwik setup behind a reverse proxy. The reverse proxy will proxy requests to example.org/analytics to the piwik web server with piwik installed in subfolder piwik within the document root. Consequence is, that the piwik logo won't show up because the URI https://example.org/piwik/themes/default/images/logo.svg is used whereas https://example.org/analytics/piwik/themes/default/images/logo.svg would be correct in this case. This also leads to the Real Time Visitor Map not being usable because several files won't be loaded (world.svg, cities.png, regions.png, ). Instead an empty content div is displayed. |
|
If you have a working patch, I would consider it, otherwise I dont know how to solve this problem |
Hi there,
There is a small bug affecting our Piwik's deployments with custom logo.
Internally we are using a Vhost on our VPN : piwik.ourcompany.com but to connect to Piwik but for our customers we are using a reverse proxy in www.ourcustomer.com/piwik/
Putting a reverse proxy allow us to remove warning from browsers regarding SSL certificates. This way the only SSL certificate seen is the one from our customer's website.
With the current Piwik code (1.8.2) the URL generated for the logo is www.ourcustomer.com/themes/logo.png instead of www.ourcustomer.com/piwik/themes/logo.png. The custom logo is displayed correctly however internally.
I attached a very simple patch to use the relative URL and solve this bug. With this the the logo is displayed correctly both internally and through the reverse proxy, as well as in PDF reports.
Let me know if there is a valid reason behing using Piwik::getPiwikUrl() instead of the relative URL.
Cheers
LeTic
Update : Remove http's to not be considered a spammer
The text was updated successfully, but these errors were encountered: