Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a composer package for the PHP Tracker only #327

Closed
ThaDafinser opened this issue Jun 24, 2014 · 4 comments
Closed

Create a composer package for the PHP Tracker only #327

ThaDafinser opened this issue Jun 24, 2014 · 4 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.

Comments

@ThaDafinser
Copy link
Contributor

A composer package only for this part:
https://github.com/piwik/piwik/tree/master/libs/PiwikTracker

Otherwise (if you want to use composer) you have to install Piwik completely...

Best: create a seperate project for it
@mattab
Copy link
Member

mattab commented Jun 24, 2014

That's a great suggestion, it would be useful. Feel free to submit pull request if you can 👍
I created repository here: https://github.com/piwik/piwik-php-tracking

@ThaDafinser
Copy link
Contributor Author

@mattab forgot to add my working example. See here:
https://github.com/ThaDafinser/piwik-tracker
https://packagist.org/packages/thadafinser/piwik-tracker

Shall i send a PR with just with the 2 files? Then i can remove my repo again.

@ThaDafinser
Copy link
Contributor Author

@mattab since this would be a BC break anyway.

Shall i make some refactoring?

  • namespace
  • cleanup (split it)
  • unitTests
  • ...

@ThaDafinser
Copy link
Contributor Author

Closing and continuing here: matomo-org/matomo-php-tracker#1

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 20, 2014
@mattab mattab mentioned this issue Dec 17, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattab @ThaDafinser