That's an epic pull request.... well done Julien!
Feedback:
cursor:pointer
Yes
, Got: -
Excluded Parameters
should be Excluded<br>Parameters
Enter a comma separated list of all query parameter names containing the site search keyword.
should be displayed on same level as its input field Query parameter
. Got: inline help displayed below input field.Category parameter
inline helpAdd a new website
the screen should scroll to the row for the new website (maybe missing piwikHelper.lazyScrollTo
?)Yes / No
, Got: Cancel / Ok
When a website is being edited:
or Cancel
should be black color, on a new line (got: blue color, on same line as "Save" button")margin-top:50px
or similar (got: one line break after website name input field)submitSiteOnEnter
missing?)Minor code cosmetics
{ }
(eg. in API.php)// can probably be shared
Very clean code... it will for sure serve as inspiration for our future AngularJS work. Well done mate!
Well done @JulienMoumne this is impressive work!
It's very nice to see you leading the way in our AngularJS migration.
Looking forward to seeing more of this @JulienMoumne :)