Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #3838 - SitesManager fully migrated to AngularJS #324

Merged
merged 17 commits into from Jul 2, 2014
Merged

refs #3838 - SitesManager fully migrated to AngularJS #324

merged 17 commits into from Jul 2, 2014

Conversation

julienmoumne
Copy link
Member

No description provided.

@mattab
Copy link
Member

mattab commented Jun 20, 2014

That's an epic pull request.... well done Julien!

  • in the build there's an integration test file missing: test_apiGetReportMetadata__API.getIpFromHeader.xml which you can generate with: phpunit Integration/ApiGetReportMetadataTest.php
  • Ping @tsteur our resident AngularJS expert. Would you mind helping Julien with code review?

@mattab
Copy link
Member

mattab commented Jun 25, 2014

Feedback:

  • on hover on a row, show cursor:pointer
  • on click on a row, it should edit the clicked website
  • when 'Edit' or 'Delete' links are hovered, put them underlined
  • when a website is ecommerce enabled, in the table, Expected: Yes, Got: -
  • to save some horizontal space, the column heading Excluded Parameters should be Excluded<br>Parameters
  • when websites are loading in the table, display "Loading..."
  • the tooltip Enter a comma separated list of all query parameter names containing the site search keyword. should be displayed on same level as its input field Query parameter. Got: inline help displayed below input field.
  • same with Category parameter inline help
  • when clicking Add a new website the screen should scroll to the row for the new website (maybe missing piwikHelper.lazyScrollTo?)
  • when deleting a website, in the popover, Expected buttons: Yes / No, Got: Cancel / Ok
  • The timezone selector is missing the timezone groups (displayed in bold)

When a website is being edited:

  • or Cancel should be black color, on a new line (got: blue color, on same line as "Save" button")
  • Save button should have a margin-top:50px or similar (got: one line break after website name input field)
  • Pressing Enter key, should be same as clicking Save button (maybe submitSiteOnEnter missing?)

Minor code cosmetics

  • single statement should have braces { } (eg. in API.php)
  • comaDelimitedFieldToArray should be commaDelimitedFieldToArray
  • maybe you could ask Thomas his opinion about places tagged // can probably be shared

Very clean code... it will for sure serve as inspiration for our future AngularJS work. Well done mate!

mattab pushed a commit that referenced this pull request Jul 2, 2014
refs #3838 - SitesManager fully migrated to AngularJS
@mattab mattab merged commit 29bb402 into matomo-org:master Jul 2, 2014
@mattab
Copy link
Member

mattab commented Jul 2, 2014

Well done @julienmoumne this is impressive work!

It's very nice to see you leading the way in our AngularJS migration.

@julienmoumne julienmoumne deleted the 3838 branch July 2, 2014 09:03
@tsteur
Copy link
Member

tsteur commented Jul 2, 2014

Looking forward to seeing more of this @julienmoumne :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants