New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Flag icons (attached) #3216
Comments
Thanks for the great submission. I agree these flags look much better. Do PDF reports generate OK with these flags? |
Attachment: Sample report with updated flag icons |
I think I missed some code changes. in /plugins/UserCountry/API.php, lines 41-42 should be updated with the new icon sizes to:
I'll update the zip. |
Attachment: "/plugins/UserCountry/". Icon sizes changed to 16x11 |
Thanks for adding the PDF. Flags look good. Not sure about the other icons but why not, at least some of them. |
@matt: should I update the flags with those attached in the zip file? |
I re-took a good look and yes the new flags are really more clear, light and nice to look at. Thanks for making this commit & arminrosu for the patch :) |
(In [6712]) fixes #3216 updated flag icons |
(In [6713]) Refs #3216 adjusting right size of new flags, since the size is hardcoded in the UI. |
Replying to SteveG:
"SS" is South Sudan (a new country, established last year afaik) and it should have a flag in the new set. If not, I will make one. But yes, there are quite a few country codes which aren't used anymore (e.g. "su" - Soviet Union). While updating the icons, I didn't remove these, for backwards compatibility. An up to date and complete list of country codes is here: Also there are 4 codes which lead to either blank (white flag) or question flags. These I left alone as well, since it wasn't clear to me what their respective uses actually where. So yes, I think a clean-up would be warranted (I could try next week), but are these flags used only by the UserCountry plugin? |
There are flags for pseudo-codes (from MaxMind's GeoIP database, e.g., A1, O1), unofficial (e.g., TI) and obsolete country codes (e.g., YU). I would like to see these updated to reflect the new size and appearance (i.e., without the wavering flag shadow), but that's just me. |
Absolutely I agree it would be really nice if all the flags could look the same! Also I noticed some flags like UK look really bright and others like france look pretty grey... that looks funny I think! Would anyone be interested in converting the remaining old flags, or at least the unkown '?' flag), to the new style ? |
Attachment: Flags only, should be complete |
Sorry, it seems I uploaded the wrong zip the first time. The set should be complete now. I will add / modify any flags you like. Regarding the different brightnesses, I considered them weird too, but making them "color correct" would have made them harder to distinguish (at least that's my take on it - 99% were done by famfam). |
(In [6789]) refs #3216 updated flag icons |
Thanks arminrosu and Stefan, looks really nice! :) @arminrosu if you have other suggestions on piwik UI please let us know: we are always interested to making Piwik look better and more usable |
That improvement was really cool... thanks again guys |
The current flag icons seem really dated. Thus I replaced them with the flags by famfam.
Some were missing (e.g. unkown, antarctica, soviet union), so I created those myself.
I'm also wondering, if some flags are still used (e.g. Yugoslavia)
Preview:
http://imgur.com/HGGOh
All images were optimized, meaning the new set is also about 47% smaller.
The text was updated successfully, but these errors were encountered: