@mattab opened this Issue on June 6th 2012 Member

As per title: Increase websites from listing 10 currently to listing up to 200 max in Report to load by default > Dashboard for a specific website

Reported in forum

@diosmosis commented on July 20th 2012 Member

Attachment: Patch for this issue.

@diosmosis commented on July 20th 2012 Member

I uploaded a patch for this issue that makes it possible to use the website selector in different places and puts it to use in the UsersManager screen. matt, can you review it and let me know what you think?

@mattab commented on July 23rd 2012 Member

Thanks for the patch!

  • Can you please put some short but to the point comments in the JS code eg. sites_selection.tpl and autocomplete.js?
    • Also when you see older code especially javascript that would be better with a comment please consider adding it also.
  • Code looks good and changes quite simple - I didn't apply the patch locally but please commit and I'll look then!
@diosmosis commented on July 25th 2012 Member

(In [6556]) Fixes #3202, allowed site selector widget to be used in other places than the top bar, and put widget to use in 'report to load by default' setting.

@diosmosis commented on July 25th 2012 Member

Committed. Regarding updating old JS code: I think it might be a good idea to rewrite the widgets as jquery plugins, when the opportunity allows. So you could use more than one of the widgets on the same page, etc. For site selector, the use would change to:

@mattab commented on July 27th 2012 Member

Getting many NOTICE errors when loading the user settings page: Notice: Undefined index: rawDate in piwik\svn\trunk\tmp\templates_c\%%2E^2E7^2E7E144D%%sites_selection.tpl.php on line 10

see email for more

@diosmosis commented on July 27th 2012 Member

(In [6579]) Refs #3202, remove unnecessary hrefs from site selector and hide all sites link when selector used in user settings.

@diosmosis commented on July 27th 2012 Member

I think I've fixed those issues, but I can't check. For some reason, I can't reproduce the notices, even though I can prove they're happening (nothing in the screen or the log). Let me know if my commit does the trick.

@mattab commented on July 29th 2012 Member

Code review:

  • Thanks that's beautiful! perfect in fact.... :)
  • Could you please also refactor all of the inline javascript code in the sites_selection.tpl refactored into the common.js ? This way all this content won't be loaded on each piwik first page load, speeding up a bit :)
  • also, it would be great to finish the refactoring of the selectors and also update the Site selector in "Settings > Users". This one has a particularity: there is an option to select "Apply to all websites". This could be at the top of the website selector in bold, and below the list of sites.
    • Once this one is converted all sites selectors will be consistent ensuring good user experience :-)
@mattab commented on July 29th 2012 Member

I noticed a regression: clicking on a site in the selector should collapse the selector. this way the user eyes focus on the Loading indicator at the right, this shows well that the click was taken into consideration

@diosmosis commented on July 31st 2012 Member

(In [6616]) Refs #3202, added modified access manager page & visitor generator plugin to use the autocompleting site selector.


  • Moved inline site selector javascript to autocomplete.js.
  • Added the ability to change the current url (via broadcast.propagateNewPage) w/o showing the main AJAX loading gif.
@diosmosis commented on August 1st 2012 Member

(In [6627]) Refs #3202, fix notice in sites_selection.tpl.

@diosmosis commented on August 1st 2012 Member

(In [6629]) Refs #3202, fix bug in sites_selection.tpl that affected VisitorGenerator.

@mattab commented on August 2nd 2012 Member

Very Nice work :)

This Issue was closed on August 2nd 2012
Powered by GitHub Issue Mirror