initial proposition of fixing http://dev.piwik.org/trac/ticket/5356 #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for pull request. unfortunately I could not reproduce issue yet. Maybe you can help me reproduce issue? see my comment in: http://dev.piwik.org/trac/ticket/5356#comment:1 |
mattab
added a commit
that referenced
this pull request
Jul 1, 2014
(the only change was to set default timezone to UTC)
|
This was fixed in de6104d unfortunately I didn't manage to add test case to reproduce the bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clearly also needs unit tests failing on current code state, and passing after fixes.
Could you please give me a hint where such test should be placed ?
Also maybe Period/Factory could use some review regarding other possible timezone issues ?