Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isMobile/isDesktop segments #3157

Closed
diosmosis opened this issue May 29, 2012 · 2 comments
Closed

add isMobile/isDesktop segments #3157

diosmosis opened this issue May 29, 2012 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Milestone

Comments

@diosmosis
Copy link
Member

Using some of the changes from #3133, we can add two new segments, isMobile & isDesktop. They would have to be views that are transformed into existing segments, ie, isMobile -> operatingSystem==ios,operatingSystem==psp,etc. . This isn't currently done and it may take some work to make it possible.

@mattab
Copy link
Member

mattab commented May 29, 2012

Could be done around:

Index: Segment.php
===================================================================
--- Segment.php (revision 6368)
+++ Segment.php (working copy)
@@ -104,6 +104,8 @@

             $sqlName = $segment['sqlSegment'];

+            // somewhere here we could read a 'viewSegment' and use this instead of a segment meaning a SQL field
+            
             // check permission
             if(isset($segment['permission'])
                 && $segment['permission'] != 1)

@mattab
Copy link
Member

mattab commented May 30, 2013

See: #3961

Let's add it to our Custom Segments examples

@diosmosis diosmosis added this to the 2.x - The Great Piwik 2.x Backlog milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Development

No branches or pull requests

2 participants