@diosmosis opened this Issue on May 29th 2012 Member

Using some of the changes from #3133, we can add two new segments, isMobile & isDesktop. They would have to be views that are transformed into existing segments, ie, isMobile -> operatingSystem==ios,operatingSystem==psp,etc. . This isn't currently done and it may take some work to make it possible.

@mattab commented on May 29th 2012 Member

Could be done around:

Index: Segment.php
--- Segment.php (revision 6368)
+++ Segment.php (working copy)
@@ -104,6 +104,8 @@

             $sqlName = $segment['sqlSegment'];

+            // somewhere here we could read a 'viewSegment' and use this instead of a segment meaning a SQL field
             // check permission
                 && $segment['permission'] != 1)
@mattab commented on May 30th 2013 Member

See: #3961

Let's add it to our Custom Segments examples

This Issue was closed on May 30th 2013
Powered by GitHub Issue Mirror