Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disableGenericFilters in ViewDataTable has no effect #3155

Closed
diosmosis opened this issue May 26, 2012 · 1 comment
Closed

disableGenericFilters in ViewDataTable has no effect #3155

diosmosis opened this issue May 26, 2012 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone
1.8

Comments

@diosmosis
Copy link
Member

The function ViewDataTable::disableGenericFilters will set $this->variablesDefault[ "disable_generic_filters" ] to true, but this data is never used again. So the function has no real effect. This should be fixed w/o causing any regressions. I think currently only the Live plugin calls this function.
@mattab
Copy link
Member

mattab commented May 28, 2012

I think it's useful:

    $requestString .= '&disable_generic_filters='.Piwik_Common::getRequestVar('disable_generic_filters', 1, 'int');

and is used in ResponseBuilder

    if(0 == Piwik_Common::getRequestVar('disable_generic_filters', '0', 'string', $this->request))

@diosmosis diosmosis added this to the Piwik 1.8 milestone Jul 8, 2014
@mattab mattab added the wontfix label Aug 3, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
1.8
Development

No branches or pull requests
2 participants
@diosmosis @mattab