Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getPrettyNumber in all relevant parts of Piwik #3154

Closed
diosmosis opened this issue May 26, 2012 · 2 comments
Closed

Use getPrettyNumber in all relevant parts of Piwik #3154

diosmosis opened this issue May 26, 2012 · 2 comments
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
1.x

Comments

@diosmosis
Copy link
Member

Piwik::getPrettyNumber, which turns 1000000 into 1,000,000 or 1.000.000 should be used on every numeric value in Piwik to make report data more readable. I think this can be done by:

  • Modifying existing prettify-ing functions so they make use of Piwik::getPrettyNumber.
  • Creating a generic DataTable filter that applies getPrettyNumber to metrics that have no unit (ie, visits). Would have to be applied by ViewDataTable, not the API.

Should probably be done after widget integration testing is up and running.
@mattab
Copy link
Member

mattab commented May 28, 2012

Sounds like a good plan! Alternatively we could do it in a Smarty filter with a regex... but hoooking in datatatable is doable too (and yes, not in the API result)

@mattab
Copy link
Member

mattab commented Dec 14, 2012

Merged in: #1254 (Nunber internationalization)

@diosmosis diosmosis added this to the 1.x - Piwik 1.x milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
1.x
Development

No branches or pull requests
2 participants
@diosmosis @mattab