Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goals conversion : url encoding problem #3146

Closed
anonymous-matomo-user opened this issue May 16, 2012 · 4 comments
Closed

Goals conversion : url encoding problem #3146

anonymous-matomo-user opened this issue May 16, 2012 · 4 comments
Assignees
@mattab
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
2.13.0

Comments

@anonymous-matomo-user
Copy link

Hello,
I have a goal tracking clics on an external link which downloads a file. The filenames can have special characters like "spaces".

The goal is set with the encoded URL copied directly from the site like "my%20file%20link.pdf". With this encoded filename, the goal is never converted. With the non-encoded filename like "my file link.pdf", it's converted.

Maybe Piwik should handle this use case and convert goals even with encoded URLs.
@robocoder
Copy link
Contributor

No. Apache/PHP already does a decode for %xx. If we do another decode, we make it harder to specify literal %xx. It could also inadvertently provide hackers with a method to bypass filters like mod_security.

At best, we could add some JavaScript to the forms that would warn if the URL appears to contain encoded characters and offer to decode on the client side before submitting.

@mattab
Copy link
Member

mattab commented Oct 19, 2012

see related #3549

@mattab
Copy link
Member

mattab commented Mar 16, 2014

Let's try to reproduce to see if this bug still applies.

See also related #3863

@anonymous-matomo-user anonymous-matomo-user added this to the 2.5.0 - Piwik 2.5.0 milestone Jul 8, 2014
@mattab mattab mentioned this issue Nov 20, 2012
Closed
@mattab mattab removed the P: normal label Aug 3, 2014
@mattab mattab self-assigned this Apr 9, 2015
mattab added a commit that referenced this issue Apr 9, 2015
@mattab
when matching Goals against patterns, match both the RAW pattern and …
aeccb71 
…URL decoded pattern

Fixes #3146
@mattab mattab mentioned this issue Apr 9, 2015
Merged
@mattab mattab modified the milestones: Piwik 2.13.0, Short term Apr 9, 2015
@mattab
Copy link
Member

mattab commented Apr 9, 2015

it's a 2.5 year old bug and this time decided to tackle it and it took 20min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
2.13.0
Development

No branches or pull requests
3 participants
@mattab @robocoder @anonymous-matomo-user