Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove morpheus priority, which broke custom themes. #313

Closed
czolnowski opened this issue Jun 12, 2014 · 3 comments
Closed

Remove morpheus priority, which broke custom themes. #313

czolnowski opened this issue Jun 12, 2014 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.

Comments

@czolnowski
Copy link
Contributor

This priority order cause that all morpheus stylesheets are loaded at very end of generated css file and custom theme rules are overwritten by morpheus.

This line cause that problem:
https://github.com/piwik/piwik/blob/master/core/AssetManager/UIAssetFetcher/StylesheetUIAssetFetcher.php#L22
@mattab
Copy link
Member

mattab commented Aug 3, 2014

Hi @czolnowski, is this issue still valid in your opinion, or is theming working as expected in 2.4.1?

@mattab mattab added the bug label Aug 3, 2014
@mattab
Copy link
Member

mattab commented Aug 3, 2014

Closing @czolnowski please ping me if this should be re-opened!

@mattab mattab closed this as completed Aug 3, 2014
@czolnowski
Copy link
Contributor Author

Theming works very well in 2.4.1. I think that we solved this problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattab @czolnowski