Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer: support mysqlnd persistent connections #3126

Closed
robocoder opened this issue Apr 26, 2012 · 4 comments
Closed

Installer: support mysqlnd persistent connections #3126

robocoder opened this issue Apr 26, 2012 · 4 comments
Assignees
@robocoder
Labels
c: Performance For when we could improve the performance / speed of Matomo. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@robocoder
Copy link
Contributor

For mysqli, you only have to prepend host with "p:" but currently, must edit config.ini.php manually to do so.

We should allow this at time of installation. However, in plugins/Installation/Controller.php databaseSetup() tries to parse a port if a colon is present, and so incorrectly splits this into host=p, port=localhost.

For PDO, I believe we have to set persistent = true.
@robocoder
Copy link
Contributor Author

We can detect the mysqli extension is built with mysqlnd if one of the following functions exists: mysqli_get_client_stats(),
mysqli_get_connection_stats(), or mysqli_get_cache_stats().

We can't detect whether or not PDO_MYSQL is built with mysqlnd. We could infer its presence by the presence of mysqlnd.* ini settings, e.g., count(ini_get_all('mysqlnd')) > 0

@mattab
Copy link
Member

mattab commented May 3, 2012

AFAIK persistent connections would be useful mostly for the Server log parsing use case?
Or do you think / tests show that it could benefit other standard use cases as well?

@mattab
Copy link
Member

mattab commented Dec 14, 2012

Not as critically important now that we have a BUlk tracking API and Bulk analytics API... they use 1 Mysql connection for 100 or 500 visits/pageviews.

Leaving open since it would still benefit some users for sure. Linked from #1999

@mattab
Copy link
Member

mattab commented Feb 4, 2014

Since we now have bulk tracking via our tracking API, which can be used with the Log Analytics tool, and that we have implemented + documented the new Log Replay / High scalability tracking (click to read the FAQ) #3632

ie. this ticket is not required anymore

@robocoder robocoder added this to the Future releases milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
@mattab mattab mentioned this issue Aug 3, 2014
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robocoder robocoder

Labels
c: Performance For when we could improve the performance / speed of Matomo. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattab @robocoder