Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to customize the maximum URL split which defaults to 10 URL directories max #3102

Closed
mattab opened this issue Apr 11, 2012 · 4 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Apr 11, 2012

The harcoded "10" should be customizable via config file setting.

See in plugins/Actions/Actions.php

$limitLevelSubCategory = 10

@diosmosis
Copy link
Member

(In [6278]) Fixes #3102, added config setting 'action_category_level_limit' as replacement for Piwik_Actions::$limitLevelSubCategory constant.

@mattab
Copy link
Member Author

mattab commented May 21, 2012

Thanks for the change. It allows up to level 15, but in this case we would liket o really allow for more which some users will want to do for sure ;)

So I propose to add a setter on DataTable to increase the MAXIMUM_DEPTH_LEVEL_ALLOWED which should be changed to a private member.

This way it would work in all cases. We don't need to enforce an absolute max, users will be careful changing these values and know what risks they take (php memory exhausted error mainly)

@diosmosis
Copy link
Member

(In [6294]) Fixes #3102, removed upper limit for 'action_category_level_limit' config setting by making MAXIMUM_DEPTH_LEVEL_ALLOWED settable.

@mattab
Copy link
Member Author

mattab commented May 24, 2012

(In [6307]) Refs #3102 removing unused function

@mattab mattab added this to the Piwik 1.8 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

2 participants