Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login flow #310

Merged
merged 2 commits into from Jun 10, 2014
Merged

Login flow #310

merged 2 commits into from Jun 10, 2014

Conversation

czolnowski
Copy link
Contributor

I added hooks and comments to them directly in Auth class. Also I changed names of these events, to be consistent with the naming convention used in this class.
As a minor change I've renamed function processSuccessfullSession. (phpstorm spellchecker has problem with this)
If you have any questions or other vision how to write this then feel free to contact me!

@mattab
Copy link
Member

mattab commented Jun 10, 2014

Looks good, I like how you named the 'Login.authenticate' and 'Login.authenticate.successful'

I'll merge it now, but for completion, maybe you'd like to add the 'Login.authenticate.failure' event?

@czolnowski
Copy link
Contributor Author

No problem. I'll add failure Hood.

mattab pushed a commit that referenced this pull request Jun 10, 2014
@mattab mattab merged commit ba8514f into matomo-org:master Jun 10, 2014
@mattab
Copy link
Member

mattab commented Jun 10, 2014

I talked too early, let's add not add un-needed events, this was bad idea ;) it's good as it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants