bug in isArchivingDisabled() ? #3072
Labels
Bug
For errors / faults / flaws / inconsistencies etc.
Major
Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
worksforme
The issue cannot be reproduced and things work as intended.
public function isArchivingDisabled()
{
$processOneReportOnly = !$this->shouldProcessReportsAllPlugins($this->getSegment(), $this->period);
if($processOneReportOnly)
{
// When there is a segment, archiving is not necessary allowed
// If browser archiving is allowed, then archiving is enabled
// if browser archiving is not allowed, then archiving is disabled
if(!$this->getSegment()->isEmpty()
&& !$this->isRequestAuthorizedToArchive()
&& Zend_Registry::get('config')->General->browser_archiving_disabled_enforce
)
{
Piwik::log("Archiving is disabled because of config setting browser_archiving_disabled_enforce=1"winking smiley;
return true;
}
return false;
}
$isDisabled = !$this->isRequestAuthorizedToArchive();
return $isDisabled;
}
Hallo to all,
I got to talk to you about this little function (from archive processing) again. It's essential because if this function returns false archives will be processed. In most cases this is a good thing, but here is my case:
I have a little plugin in piwik 1.6 with some tables. I want to use auto archivieng, berause of performanceissues. The problem here is, some of my tables use segmantation and some not. Now the function above returns always false, if segmantation is used. This leads to inconsistency, because the tables with segmantation will be archived immediately while the tables without have to wait until the crontab triggers the archiving.
So in my eyes this is a bug. Whats your opinion?
I think the source for the problem is this line:
Zend_Registry::get('config')->General->browser_archiving_disabled_enforce
When I disable browser_archiving, it returns '0' never the less. But according to the comments it should return true. This would disable the archiving (like the comments say). Furthermore I already tested to negotiate the line like this:
!Zend_Registry::get('config')->General->browser_archiving_disabled_enforce
and it works fine.
So if you agree with me that this is a bug, I would be glad if someone from the piwik team could fix it.
Thanks
Davud
The text was updated successfully, but these errors were encountered: