Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glitch in piwik/core/common.php #3068

Closed
anonymous-matomo-user opened this issue Mar 23, 2012 · 2 comments
Closed

Glitch in piwik/core/common.php #3068

anonymous-matomo-user opened this issue Mar 23, 2012 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone
1.12.x

Comments

@anonymous-matomo-user
Copy link

Hello,
Not that this is such an issue, but strictly speaking, "self" should be used instead of "Piwik_Common" within the Piwik_Common class :

Piwik_Common::getCacheGeneral()
Piwik_Common::initCorePiwikInTrackerMode()
Piwik_Common::sanitizeInputValue()
Piwik_Common::HTML_ENCODING_QUOTE_STYLE
@anonymous-matomo-user
Copy link
Author

Is there any reason to use Piwik_Common instead of self there ?

Please enlighten me.

@robocoder
Copy link
Contributor

Usually it's just a matter of personal coding style.

But if you refer to #2954, there are also backward compatibility issues.

@anonymous-matomo-user anonymous-matomo-user added this to the 1.12.x - Piwik 1.12.x milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
1.12.x
Development

No branches or pull requests
2 participants
@robocoder @anonymous-matomo-user