Device detector2 cache #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By caching parsed DeviceDetectors, we reduce the number of regexes to process. It allows to process more requests per second when the same user agent is met.
| $deviceDetector->setCache(new DeviceDetectorCache('tracker', 86400)); | ||
| $deviceDetector->parse(); | ||
| static $deviceDetectorsCache; | ||
| $deviceDetectorsCache = new CacheStatic(); |
There was a problem hiding this comment.
Making that variable static doesn't make sense if it is always set to a new instance. Could you add an check if the variable has already been set before?
|
You're right, I converted the code too quickly to the DeviceDetector2 branch. I'm going to push a commit that reverts the code to the one I used on master. |
The previous commit had at least 2 issues : one identified by sgiehl, who reported that the static variable was useless if we always create a new cache instance, and indeed, he's absolutely right ! Another one can be classified as a potential security issue, where a request can forge a user agent as a key to an object which is not meant to be accessed (CacheStatic instances share their data).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch provides an optimization that caches the parsed DeviceDetector.
Using The DeviceDetector2 branch, before the patch, a test case with 100000 line extracted from a real website, the result was :
Total time: 308 seconds
Requests imported per second: 323.87 requests per second
After the patch :
Total time: 144 seconds
Requests imported per second: 690.84 requests per second
The optimization really depends on the number of different user agents and the bulk size but in the worst case, we can expect nearly the same performance as without the patch.
Note : initially, I expected to provide the patch for the master branch but I prefered to provide one for the DeviceDetector2 branch, using CacheStatic instead of a static array.