Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trunk testing: selecting desired PHP version #3036

Closed
robocoder opened this issue Mar 12, 2012 · 2 comments
Closed

trunk testing: selecting desired PHP version #3036

robocoder opened this issue Mar 12, 2012 · 2 comments
Assignees
@robocoder
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@robocoder
Copy link
Contributor

Right now, the PHP version (and some runtime options) used by the CI server for testing can be set by Jenkins via environment variables, e.g.,

  • PHP_VERSION - the default is currently 5.3.10

However, these env vars are lost when using curl requests; the server then falls back to the defaults.

This ticket proposes:

  • on curl requests to localhost or 127.0.0.1, we set an X- header for the desired PHP version, e.g., X-PHP; this can be further protected by a config option (default suppresses this header) or maybe an alternate adapter (i.e., if we refactor Http.php)
  • the php-cgi wrapper script would then select the PHP version specified by (in order of preference) X_HTTP_PHP, PHP_VERSION, default.
@mattab
Copy link
Member

mattab commented Mar 20, 2012

Does it mean that we are closer to being able to test multiple PHP versions on Jenkins? :)

X- header is a good solution, only set the header when the config setting was set (which should only be used on the Piwik QA server and not by users anyway).

+1

@robocoder
Copy link
Contributor Author

Don't have the time to build a custom solution. Travis-ci makes this easy.

@robocoder robocoder added this to the Future releases milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robocoder robocoder

Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattab @robocoder