@robocoder opened this Issue on March 10th 2012 Contributor

With E_STRICT, we're getting the following errors:

Unexpected PHP error variables should be passed by reference severity [E_STRICT]

Review where we use reset(), current(), end(), each(), prev(), and next().

@robocoder commented on March 10th 2012 Contributor

(In [6031]) fixes #3030 - php 5.4.0 incompatibilities with E_STRICT

Now that php 5.4.0 is "official", I've bumped the CI server up to using that as the default php version.

@robocoder commented on March 10th 2012 Contributor

segfault...

@robocoder commented on March 10th 2012 Contributor

(In [6032]) refs #3030 - for debug

@robocoder commented on March 10th 2012 Contributor

(In [6033]) refs #3030 - revert debug

@robocoder commented on March 10th 2012 Contributor

I'm not getting any useful debugging information from the log files.

2012-03-10 17:54:22.158:WARN::Non-zero exit status (255) from CGI program: /..../build/index.php
2012-03-10 17:54:23.436:WARN::Non-zero exit status (139) from CGI program: /..../build/index.php
Segmentation fault
@robocoder commented on March 10th 2012 Contributor

p.s. I rolled back to php 5.3.10 on the CI server

@robocoder commented on March 11th 2012 Contributor

I couldn't reproduce this locally. I had to disable display_errors and E_STRICT to get Piwik 1.0 to install. But it updated to trunk without error.

@mattab commented on March 12th 2012 Member

Great job Anthon on the 5.4 work. You are our Samurai of the bleeding edge technologies ;)

@mattab commented on March 20th 2012 Member

(In [6068]) refs #3030 Honour php.ini setting.

The fact that errors are displayed is one of the key factors that help us troubleshoot users, losing error and NOTICES messages would be a lot more support pain...

we still recommend power users to set it to off: http://piwik.org/security/how-to-secure-piwik/

This Issue was closed on March 20th 2012
Powered by GitHub Issue Mirror