This is beautiful!
There is a test failing on Travis-CI right now https://travis-ci.org/piwik/piwik/jobs/4901170/#L90 - is that reasonable or did you remove a widget from the list? Let me know and I'll merge + fix the test.
I have not touched the test suite at all. Maybe it still looks for the old widget, I don't know...
I'll look into it and make sure it works. Nice changes btw. - and great to see Tibet among the list of countries!
Can I suggest rebasing (squashing commits) before merging?
Will do that.
another small note: Maybe we shouldn't use plugin specific translation files for plugins in core. Those translations should be moved to the main translation files in /lang. That way it's easier to maintain those with OTrance.
OK - Rebase on this is not trivial, there are quite a number of merge conflicts which I have to look into. If someone else takes a shot at this: Don't just squash everything into a single commit, we would loose too much history then.
I think this time it's fine to just merge the pull request. I was not expecting that my branch would be rebased, that's why I did all these auto-commits during development. Essentially it's a complete new feature, developed from scratch.
That's fine, yet merging >250 commits with "auto commit" isn't really usefull, so at least these should be rebased/squashed into a single commit.
@halfdan would you mind merging the pull request?
or do I just click "Merge pull request" ?
I am working on it. There is some stuff that I want to filter-branch out before pushing the merge.
weird stuff appeared