Login flow processor #299
Closed
Login flow processor #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
added a commit
that referenced
this pull request
Jun 2, 2014
Refs #299 - instead of creating loginFlow object, maybe we can throw events from the methods `processFailedSession()` and `processSuccessfullSession()`
|
I tried to refactor Auth class following your suggestion. But i don't really understand the naming of events you chose, in the login flow object. IMHO it would be better to put hooks in the Auth object to keep things clear, and always name hooks according to method they are triggered from. Also let's add a comment to the hook so it shows up in the documentation here: http://developer.piwik.org/api-reference/events (this page is automatically generated from the source code comments). Let me know what you think... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Login flow processor using to hook up into init session process as next layer of authenticate.