Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smarty 3.1.8 patch #2983

Closed
robocoder opened this issue Feb 27, 2012 · 5 comments
Closed

Smarty 3.1.8 patch #2983

robocoder opened this issue Feb 27, 2012 · 5 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@robocoder
Copy link
Contributor

Patch from V.Krishn to update Smarty from 2.6.26 to 3.1.8 (originally posted to the piwik-hackers mailing list).
@robocoder
Copy link
Contributor Author

Attachment:
piwik.smarty3.tar.gz

@robocoder
Copy link
Contributor Author

Note: Smarty has a minimum php 5.2 requirement.

Note: we have a custom version of Smarty 2.6.26 because local bug fixes were reported but never merged upstream.

@mattab
Copy link
Member

mattab commented Feb 27, 2012

If there is no security fix, we might not want to upgrade. Because requiring 5.2 would be potentially dangerous for existing users?

@robocoder
Copy link
Contributor Author

We can test for (and workaround) 5.1.x regressions. I'm more interested in seeing if our local mods have been addressed in 3.x, and performance improvement.

@mattab
Copy link
Member

mattab commented Dec 14, 2012

please reopen if patch is valid and you think should be applied (please explain why)

@robocoder robocoder added this to the Future releases milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattab @robocoder