@czolnowski opened this Pull Request on May 28th 2014 Contributor

Extended password validation based on hooks and PasswordValidator interface.

@mattab commented on June 2nd 2014 Member

Thanks for the suggestion!

In this case, i think it is over-engineered to add logic of password validators in core. Why generalise password validators, when we have only one in core? The goal of course is to let plugins add more validators. But In this case, IMHO it is enough to add a new event called 'UsersManager.checkPassword' in this method. Then any plugin could throw an exception when password is not valid. (and plugins can decide for themselves to implement password validators).

@mattab commented on June 10th 2014 Member

Looks good to me!

This Pull Request was closed on June 10th 2014
Powered by GitHub Issue Mirror