Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions>Page Titles believes there is a subpage if page <title> includes a forwards slash #2956

Closed
mattab opened this issue Feb 20, 2012 · 10 comments · Fixed by #13688
Closed
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Feb 20, 2012

Currently, if the html page <title> is "Test / Hello", Piwik will report in Actions > Page Titles the directory "Test", clickable to open the sub page "Hello".

This is confusing for users, because often, slash characters in the page title, does not imply a notion of hierarchy.

However, as we document it on the JS tracking doc, it is possible to set the document title to a given value and use this technique to classify page titles in a given hierarchy, eg. "Article / Sport / XYZ".

Because by default Page titles do not contain hierarchy, I propose that:

  • when setDocumentTitle is called, we do split the page title based on the slash character
  • In the default Javascript tracking code, when setDocumentTitle is not used, we do NOT split the page titles and never create the sub category.
    • Implementation wise, we could eg. have a different named argument when setdocumentTitle is called ("title") VS when the default <title> value is used (parameter currently named "action_name").

This was reported in this post, #1532, #3364, and I often got frustrated myself with this problem.

@mattab
Copy link
Member Author

mattab commented Sep 7, 2012

Also reported in #1532, #3364

@ataraxie
Copy link

What is the status on this issue? We're eagerly waiting for it's solution 😇

@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. and removed Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. labels Nov 21, 2014
@mattab mattab modified the milestones: Short term, Long term Nov 21, 2014
@cuhkrain
Copy link

Dear Mattab,

May i know if this resolved in the latest version?

My boss is asking about this strange behaviors.

Thanks.

@mdehaas
Copy link

mdehaas commented Jan 2, 2016

Since this bug is still open and no activity for almost one year... Will this bug be fixed? When? And are there workarounds to go around this problem? For the PHP Tracker I am replacing forward slashes with "-" in my code, This could also be done for the javascript code I think... I'm not using JS on a site with the issue now and am not really good at it. If anyone has a code sample to share, please do.

PHP:
$unslashed = str_replace ("/" , "-" , "Lego Stadler GTW 2/8 Full Render");
Replace the last string with the string containing the title.

@kongsted
Copy link

Why is this bug closed, and the other issue refereed to marked as "duplicate" - then it's no longer reported as a bug?

@mattab
Copy link
Member Author

mattab commented Mar 15, 2016

@kongsted this issue is still opened

@mattab
Copy link
Member Author

mattab commented Sep 28, 2017

This is an annoying issue, and probably a quick fix, so moving to 3.3.0

@mattab mattab modified the milestones: Backlog (Help wanted), 3.3.0 Sep 28, 2017
@sgiehl
Copy link
Member

sgiehl commented Sep 28, 2017

Why should that be a bug? Imho that is expected behavior. Action title reports are splitted by / as it is defined as such in config.
This is not done in JS. This is "calculated" while archiving the reports.

@mattab what would be your expected fix? Change the default character here or remove that feature for title reports?

@mattab
Copy link
Member Author

mattab commented Sep 28, 2017

what would be your expected fix? Change the default character here or remove that feature for title reports?

To bring flexibility when needed (and not break completely when some users rely on this feature), proposal is:

  • leave the feature available,
  • but disable it by default (eg. by setting empty delimiter action_title_category_delimiter=)

@mattab
Copy link
Member Author

mattab commented Sep 28, 2017

We'll need to announce it clearly in the developer changelog and the user changelog too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants