Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specification: Plugin package description #2881

Closed
robocoder opened this issue Jan 23, 2012 · 5 comments
Closed

Specification: Plugin package description #2881

robocoder opened this issue Jan 23, 2012 · 5 comments
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.0

Comments

@robocoder
Copy link
Contributor

e.g., package.json

  1. sanity checked against Piwik_Plugin::getInformation()

  2. allows detailed information to be loaded independently of the class

  3. would be used by plugin repository and in-app plugin installer

  4. could store dependency information; i.e., used to load plugins (and register observers) in the right order
@julienmoumne
Copy link
Member

+1

@robocoder
Copy link
Contributor Author

Revised requirements, no longer deprecating getInformation().

@halfdan
Copy link
Member

halfdan commented Jul 13, 2013

Regarding 1) What kind of sanity check do you have in mind? Shouldn't getInformation be removed afterwards?

@mattab
Copy link
Member

mattab commented Jul 14, 2013

  1. getInformation will be removed from each plugin class. All core plugins will be working well so we don't need sanity checks I don't think (appart from basic !empty())

Note we dont need sanity checks in core IMO because the plugin marketplace will "verify" the json file against set of rules and email the plugin developer if any problem (eg. required field missing)

  1. Observer order was implemented in Git via before/after flag, see core/Plugin getListHooksRegistered()

@mattab
Copy link
Member

mattab commented Jul 15, 2013

See new ticket for this task: JSON File for plugins #4054

@robocoder robocoder added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
4 participants
@halfdan @mattab @julienmoumne @robocoder