[SQL] Missing explicit primary key definition in table log_profiling #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't bother mysql but other databases might not be as permissive. |
mattab
pushed a commit
that referenced
this pull request
May 25, 2014
[SQL] Missing explicit primary key definition in table log_profiling Cheers for pull request!
|
That one broke the build... |
mattab
added a commit
that referenced
this pull request
May 25, 2014
|
And I'm not sure if that one made sense anyways. A unique key is not exactly the same as a primary key for sure but both don't make sense. And the definition file is not named 'MySQL.php' without a reason. The schema is for mysql only, other dbs would get another definition file. |
|
sorry shouldn't have merged that one for these reasons 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing explicit primary key definition in table log_profiling