@he667 opened this Pull Request on May 22nd 2014 Contributor

Missing explicit primary key definition in table log_profiling

@he667 commented on May 22nd 2014 Contributor

It doesn't bother mysql but other databases might not be as permissive.

@sgiehl commented on May 25th 2014 Member

That one broke the build...

@sgiehl commented on May 25th 2014 Member

And I'm not sure if that one made sense anyways. A unique key is not exactly the same as a primary key for sure but both don't make sense. And the definition file is not named 'MySQL.php' without a reason. The schema is for mysql only, other dbs would get another definition file.
And if we change the schema, we should ALWAYS also add an update script to keep all databases in sync.

@mattab commented on May 25th 2014 Member

sorry shouldn't have merged that one for these reasons

:+1:

This Pull Request was closed on May 25th 2014
Powered by GitHub Issue Mirror