Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All reports: display as much text as possible before the label is truncated #2834

Closed
mattab opened this issue Dec 24, 2011 · 23 comments
Closed
Labels
Critical Indicates the severity of an issue is very critical and the issue has a very high priority. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Dec 24, 2011

Currently, truncation in datatable is not ideal, it often truncates text too early, or does not truncate text early enough and columns are pushed out of sight.

See the 2 attached files for examples of the 2 common bugs with truncation.

Fixing truncation will make the dashboard, IMO, nearly perfect ;-)

@mattab
Copy link
Member Author

mattab commented Dec 24, 2011

Attachment:
truncation bug 2.png

@mattab
Copy link
Member Author

mattab commented Dec 24, 2011

Attachment:
truncation bug.2.png

@mattab
Copy link
Member Author

mattab commented Dec 24, 2011

One idea would be maybe to use pure CSS or use this CSS technique set dynamically with JS? http://amix.dk/blog/post/19661

@mattab
Copy link
Member Author

mattab commented Jan 26, 2012

Bumping since this issue is really one of the last ugly UI bits of Piwik.

@gaumondp
Copy link

Since there's 2 duplicates (#3765 and #4192) it's worth bumping, right? Even Matt did almost 2 years ago...

I can test but can't provide code, sorry.

Dali

@mattab
Copy link
Member Author

mattab commented Nov 22, 2013

Bumped!

@mattab
Copy link
Member Author

mattab commented Feb 1, 2014

Consolidating milestones FTW

@hpvd
Copy link

hpvd commented Mar 4, 2014

"Fixing truncation will make the dashboard, IMO, nearly perfect ;-)"
=> it's not only relevant for dashboard only, but for all tables

See also #4794

@mattab
Copy link
Member Author

mattab commented Mar 16, 2014

At the moment, connecting to the 3 column dashboard using small screen, one will not see the "Visits" or "Pageviews" columns in most reports.

@tsteur maybe your clever workaround, used in insights, could somehow be used for all datatables within Piwik? Fixing this bug would be really amazing for Piwik.

@tsteur
Copy link
Member

tsteur commented Mar 18, 2014

In 302b0cd: refs #2834 a first version of dynamic label truncation, waiting for screenshot tests to see what is broken / what changes

@tsteur
Copy link
Member

tsteur commented Mar 18, 2014

In 22cccda: refs #2834 some fixes and optimizations, for instance show tooltip only if text is ellipsized

@tsteur
Copy link
Member

tsteur commented Mar 18, 2014

In 669fefd: refs #2834 set max label column width to 440 as we might remove some pixels again because of padding

@tsteur
Copy link
Member

tsteur commented Mar 18, 2014

In 88ed837: refs #2834 do not apply max width on widget page

@tsteur
Copy link
Member

tsteur commented Mar 18, 2014

In 9cd28f5: refs #2834 fix tables are too wide in db stats plugin

@tsteur
Copy link
Member

tsteur commented Mar 19, 2014

In 1954634: refs #2834 fix subtables in widgetized keywords report are not displayed correct (inline-block was applied on td elements)

@tsteur
Copy link
Member

tsteur commented Mar 20, 2014

In 803afb0: refs #2834 should fix some characters are sometimes not completely visible, for instance a "g"

@tsteur
Copy link
Member

tsteur commented Mar 20, 2014

In 9a3e949: refs #2834 fix each line is a bit too high

@tsteur
Copy link
Member

tsteur commented Mar 20, 2014

In d04f573: refs #2834 the plusMinus icon was originally a bit further down

@mattab
Copy link
Member Author

mattab commented Mar 20, 2014

In 8b9f710: Z-index to work around https://bugzilla.mozilla.org/show_bug.cgi?id=886716 refs #2834

@tsteur
Copy link
Member

tsteur commented Mar 20, 2014

In 4fe801e: refs #2834 fix some fonts in admin

@tsteur
Copy link
Member

tsteur commented Mar 21, 2014

closing for now, will fix further issues once they pop up

@gaumondp
Copy link

Would be great if the truncation had an "overridable" setting.

Many (if not 80%) of my downloads files are +100 chars long paths and some up to 125 chars. Yes they are under 5 level depth directories. ;)

Another suggestion would be "Special widgets with no truncation at all". So we can use a Dashboard with a single widget taking all the page width.

Maybe a "start truncation from left" would also solve some problems because seeing paths without the filename at the end is quite useless...

@tsteur
Copy link
Member

tsteur commented Apr 15, 2014

Thx for your feedback! That's a good point.

As this ticket is already done I created a new ticket for this, see #4998

sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…ting for screenshot tests to see what is broken / what changes
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…move some pixels again because of padding
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…not displayed correct (inline-block was applied on td elements)
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical Indicates the severity of an issue is very critical and the issue has a very high priority. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

4 participants