Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for segmentation on Goals.getItems* API #2781

Closed
mattab opened this issue Nov 14, 2011 · 5 comments
Closed

Add support for segmentation on Goals.getItems* API #2781

mattab opened this issue Nov 14, 2011 · 5 comments
Assignees
@mattab
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
Long term

Comments

@mattab
Copy link
Member

mattab commented Nov 14, 2011

It might be the last API that does not implement $segment support. It should!

  • add $segment support parameter to all Goals API that do not yet support it.

Reported in forum post.
@robocoder
Copy link
Contributor

dyslexia

@mattab
Copy link
Member Author

mattab commented Oct 17, 2013

Pull request: #121

@mattab
Copy link
Member Author

mattab commented Dec 8, 2013

In 7778531: Merge pull request #121 from piwikpro-team/2781-segmentation-on-Goals.getItems

Fixes #2781 Add support for segmentation on Goals.getItems* API. Kuddos for the nice pull request and tests!

@mattab
Copy link
Member Author

mattab commented Dec 8, 2013

In 44d9bce: Refs #2781 PR #121 Modifying tests fixtures to generate visits from two countries so that it's clear that the Segmenting on the country selects only that country.

@mattab
Copy link
Member Author

mattab commented Dec 8, 2013

In 93d5d1f: Refs #2781 PR #121 Fixing regression the "distinct idvisit" was removed in the PR

@mattab mattab added this to the 2.x - The Great Piwik 2.x Backlog milestone Jul 8, 2014
@mattab mattab self-assigned this Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@czolnowski
matomo-org#2781
32f5135 
Improvements in queryEcommerceItems function which make it works with segments query builder
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Merge pull request matomo-org#121 from piwikpro-team/2781-segmentatio…
7778531 
…n-on-Goals.getItems

Fixes matomo-org#2781 Add support for segmentation on Goals.getItems* API. Kuddos for the nice pull request and tests!
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#2781 PR matomo-org#121 Modifying tests fixtures to ge…
44d9bce 
…nerate visits from two countries so that it's clear that the Segmenting on the country selects only that country.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#2781 PR matomo-org#121 Fixing regression the "distinc…
93d5d1f 
…t idvisit" was removed in the PR
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
Long term
Development

No branches or pull requests
2 participants
@mattab @robocoder