Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbstrings patch #2770

Closed
anonymous-matomo-user opened this issue Nov 11, 2011 · 5 comments
Closed

mbstrings patch #2770

anonymous-matomo-user opened this issue Nov 11, 2011 · 5 comments
Assignees
@robocoder
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
1.7

Comments

@anonymous-matomo-user
Copy link

We've received recent changes [and check them out. [BR]

The situation is not corrected after changes. The fact is that the functions mbstrings must explicitly specify the encoding.

Therefore, we found an excellent solution of the issue and put the next patch mbstringsDetectEncode.patch
@anonymous-matomo-user
Copy link
Author

Attachment:
mbstringsDetectEncode.patch

@anonymous-matomo-user
Copy link
Author

Attachment: fixed errors
mbstringsDetectEncodeFixed.patch

@anonymous-matomo-user
Copy link
Author

Sorry, we're a little rushed and released a patch with little bug. New patch MbstringsDetectEncodeFixed.patch doesn't contain errors.

@robocoder
Copy link
Contributor

Thanks for reviewing the commit in #2769.

Since there are other mbstring issues with workarounds in place, I think it's time to refactor.

@robocoder
Copy link
Contributor

#2769 - reopened

@anonymous-matomo-user anonymous-matomo-user added this to the 1.7 Piwik 1.7 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robocoder robocoder

Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
1.7
Development

No branches or pull requests
2 participants
@robocoder @anonymous-matomo-user