@sgiehl opened this Issue on October 23rd 2011 Member

On our meetup today a user reported problems with displaying some statistics in piwik mobile. As that were parse errors in the json string given from the server, we checked the response.

Seems to be that on his server the numberformating didn't work as expected as there were parts formated like {'key': 12,7} which is just invalid and should be {'key': 12.7}

I searched a bit, and I guess that might be a problem with older versions of PHP (<5.2.15). see https://bugs.php.net/bug.php?id=53507

I currently don't have a server with php 5.2 running, so I can't reproduce that bug.

In order to fix that issue, maybe we should set the locale to english before using json_encode and reset that afterwards.

@robocoder commented on November 13th 2011 Contributor

I think bug 53507 lists the wrong php version; I tested 5.2.6, 5.2.13 (and above) and the locale had no effect

I was able to reproduce the problem with 5.2.1. I checked the php 5 changelog, and this problem was reportedly fixed in 5.2.5.

@robocoder commented on November 13th 2011 Contributor

(In [5432]) fixes #2735

@mattab commented on November 13th 2011 Member

Cool to get this fixed, what a complicated thing to do to be cross version compatible :) but this is good.

Can you please confirm that it does not break BC for existing JSON strings (except those with the buggy php version)?

@robocoder commented on November 14th 2011 Contributor

The fallback is libs/upgradephp/upgrade.php's json_encode/json_decode, which is already used by Piwik users running PHP 5.1.x. This will now also apply to users running:

  • php 5.2.0, and
  • php 5.2.1 to 5.2.4 where the locale's decimal separator isn't '.'
@anonymous-piwik-user commented on November 21st 2011

[https://bugs.php.net/bug.php?id=53507] < can you elaborate a bit on what you see here?

@robocoder commented on December 3rd 2011 Contributor

(In [5520]) refs #2735, refs #2812

@robocoder commented on March 7th 2012 Contributor

(In [5984]) refs #2735

@mattab commented on March 7th 2012 Member

(In [5994]) refs #2735 I assume it cannot hurt

This Issue was closed on March 7th 2012
Powered by GitHub Issue Mirror