Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack to fix pie chart size on retina #271

Merged
merged 1 commit into from May 9, 2014

Conversation

BernhardValenti
Copy link
Contributor

see http://dev.piwik.org/trac/ticket/4594#comment:10

this is pretty much a quick hack, but works fine for me. i don't have time to look into jqplot more.

@mattab
Copy link
Member

mattab commented May 8, 2014

Cheers for the PR.. I will test it, but why did you change: libs/jqplot/jqplot-custom.min.js ? is it needed for this particular fix?

@BernhardValenti
Copy link
Contributor Author

it's what the build script creates, I figured it's necessary to rebuild it.
feel free to ignore if that's not the case!
On May 7, 2014 8:35 PM, "Matthieu Aubry" notifications@github.com wrote:

Cheers for the PR.. I will test it, but why did you change:
libs/jqplot/jqplot-custom.min.js ? is it needed for this particular fix?


Reply to this email directly or view it on GitHubhttps://github.com//pull/271#issuecomment-42501506
.

@mattab
Copy link
Member

mattab commented May 8, 2014

of course, silly me. Will test it now!

@mattab
Copy link
Member

mattab commented May 8, 2014

Does not work for me, using Chrome Emulate screen feature I still see the pie chart zoomed in.

@BernhardValenti
Copy link
Contributor Author

I'll check again tomorrow, definitely worked on my retina mbp though.

On Wed, May 7, 2014 at 9:54 PM, Matthieu Aubry notifications@github.comwrote:

Does not work for me, using Chrome Emulate screen feature I still see the
pie chart zoomed in.


Reply to this email directly or view it on GitHubhttps://github.com//pull/271#issuecomment-42505841
.

@BernhardValenti
Copy link
Contributor Author

just checked again, works fine for me. see screenshot. anyone else with a retina that can test?

(just pushed a version that is rebased to the latest master)

screen shot 2014-05-08 at 10 33 20 am

@mattab
Copy link
Member

mattab commented May 9, 2014

oh, my bad, I didn't apply your patch properly.

beautiful, it works! Please keep the Pull requests coming 👍

mattab pushed a commit that referenced this pull request May 9, 2014
hack to fix pie chart size on retina Fixes #4594 
Kuddos @wedgeV
@mattab mattab merged commit a5b61f4 into matomo-org:master May 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants