@wedgeV opened this Pull Request on May 8th 2014 Contributor

see http://dev.piwik.org/trac/ticket/4594#comment:10

this is pretty much a quick hack, but works fine for me. i don't have time to look into jqplot more.

@mattab commented on May 8th 2014 Member

Cheers for the PR.. I will test it, but why did you change: libs/jqplot/jqplot-custom.min.js ? is it needed for this particular fix?

@wedgeV commented on May 8th 2014 Contributor

it's what the build script creates, I figured it's necessary to rebuild it.
feel free to ignore if that's not the case!
On May 7, 2014 8:35 PM, "Matthieu Aubry" notifications@github.com wrote:

Cheers for the PR.. I will test it, but why did you change:
libs/jqplot/jqplot-custom.min.js ? is it needed for this particular fix?


Reply to this email directly or view it on GitHubhttps://github.com/piwik/piwik/pull/271#issuecomment-42501506
.

@mattab commented on May 8th 2014 Member

of course, silly me. Will test it now!

@mattab commented on May 8th 2014 Member

Does not work for me, using Chrome Emulate screen feature I still see the pie chart zoomed in.

@wedgeV commented on May 8th 2014 Contributor

I'll check again tomorrow, definitely worked on my retina mbp though.

On Wed, May 7, 2014 at 9:54 PM, Matthieu Aubry notifications@github.comwrote:

Does not work for me, using Chrome Emulate screen feature I still see the
pie chart zoomed in.


Reply to this email directly or view it on GitHubhttps://github.com/piwik/piwik/pull/271#issuecomment-42505841
.

@wedgeV commented on May 8th 2014 Contributor

just checked again, works fine for me. see screenshot. anyone else with a retina that can test?

(just pushed a version that is rebased to the latest master)

screen shot 2014-05-08 at 10 33 20 am

@mattab commented on May 9th 2014 Member

oh, my bad, I didn't apply your patch properly.

beautiful, it works! Please keep the Pull requests coming :+1:

This Pull Request was closed on May 9th 2014
Powered by GitHub Issue Mirror