Here is the current list of requests to improve ImageGraph plugin (#1721)
Also, the horizontal grey line in this screenshot is too thick, can we make it slightly smaller (1 pixel?)?
What are your thoughts guys?
I thought we could use the PDF fonts, but they are in a raw format (see https://github.com/piwik/piwik/blob/master/libs/tcpdf/fonts)
however the graph library pcharts is using GD freetype imagettf functions which require a .ttf file (currently tahoma.ttf at https://github.com/piwik/piwik/blob/master/libs/pChart.1.27d/Fonts
Is there a way we can reuse the tcpdf fonts on the graphs, to automatically handle all languages?
Or should we bundle extra .ttf to support all existing languages (potentially adding a lot of bytes to the Piwik download since these fonts are heavy...)
Would anyone know how to solve this problem? :)
Attachment:
Screenshot_148.png
Attachment:
Screenshot_150.png
Attachment: PDF Reports with graphs, showing that the legends is not frequent enough
Graphs legends not often.pdf
Attachment:
Wishlist graphs horizontal bars.jpg
Attachment: unifont demo
unifont.jpeg
Attachment: tahoma demo
tahoma.jpeg
Attachment: unifont demo
unifont.png
Attachment: tahoma demo (png seems to be better for comparison, maybe there is an even better format?)
tahoma.png
See also #2706 Support graphs in Email reports
Trunk has a license conflict. From #1721:
The pChart library contains Microsoft fonts (i.e., tahoma.ttf in pChart 1.27d and verdana.ttf in pChart 2) that don't allow for this form of redistribution. The font should be removed from the package. (The user can be instructed to install the missing font, if required.)
If the tahoma font is required, please see if the LGPL tahoma.ttf font from the Wine project works as a replacement. (Supposedly has similar/same kerning to Microsoft's.)
Take a look at GNU Unifont: http://unifoundry.com/unifont.html -- it's a pan-unicode font with lots of coverage and is included with Debian.
It's supposedly GPL v2 or higher, but there's an unanswered question in the Debian bugs database. http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=584672
Looks interesting, but very big font, as expected :)
Is there a TTF version?
When we create the PDF reports with all reports as vertical bar graph, unfortunately the report is not useful because the graphs do not show enough legends. We should, for the Keywords, Countries, Referrers, Pages, etc. show the X legend for EACH data point. The legends text would have to be vertical or diagonal to fit, and we could display maybe 10-15 maximum?
This is I believe the most urgent item to tackle to improve the Graphs :)
I'm currently investigating the comment:9 legend issue.
The best way to go forward with comment:9 is to introduce a new type of graph: horizontal bars.
I'm currently refactoring the whole ImageGraph Plugin code.
Per Anthon's suggestions, I'd like to:
However,
How do you suggest we deal with this ?
Maybe we should write the chart drawing on our own. If you also think so, I could start with this task...
I've actually almost finished updating the ImageGraph plugin to use pChart 2.1.3.
I don't think writing our own charting library is wise considering pChart has almost all we need.
Re: Fonts. Yes this is a known problem, see ticket description. Fonts from tcpdf seem to not be reusable for graphs (since not in ttf format)...
You can plug the free tahoma font in the imagegraph plugin, sure, it should just work like the other tahoma.
good luck, looking forward to seeing the result!
Wine's tahoma font has the same kerning as Microsoft's, but doesn't lacks many anti-aliasing hints, so it looks kind of ugly.
Unifont is a ttf, but font width and kerning is different.
Please discard all the tahoma examples. I used the Microsoft file.
I'm close to fixing this ticket and the two related ones (#2788 #2706).
What's stalling the progress is that we may need to modify pChart 2 source code to fix the following issue : http://sourceforge.net/tracker/?func=detail&aid=3443890&group_id=227755&atid=1071632
Also, I have yet to find a way to display icons and percentages as specified in http://issues.piwik.org/attachments/2704/Wishlist%20graphs%20horizontal%20bars.jpg
I have contacted pCharts dev by email - not sure what is the best way to get things moving faster?
Did you take a shot yourself, maybe the bug can be cracked in a few minutes ;-)
Icons & percentages, probably not possible now, would require new features in the lib. If not easy, it will be no problem committing without it!
I'll try and fix it.
Concerning LEGALNOTICE, does the wine font belong to section THIRD-PARTY CONTENT ?
Also, the pChart 2 readme mention the font files we decided to remove :
The provided font files are licensed under their own terms :
dvent_light.ttf Copyright Andreas K. inde
Bedizen.ttf Copyright Tepid Monkey Fonts
calibri.ttf Copyright Microsoft
Forgotte.ttf Copyright Ray Larabie
GeosansLight.ttf Copyright Manfred Klein
MankSans.ttf Copyright Manfred Klein
pf_arma_five.ttf Copyright Yusuke Kamiyamane
Silkscreen.ttf Copyright Jason Aleksandr Kottke
verdana.ttf Copyright Microsoft
Do we leave it that way ?
THIRD-PARTY CONTENT: yes, that's the appropriate section for non-code.
Leave pChart's readme as is. Just add a note to piwik/libs/README_LIBS mentioning the font removal.
(In [5549]) Refs #2704 Restoring _GET parameters to original values, even when an exception is thrown. This might fix some bugs in scheduled reports when
1) reports contains several graphs
2) one or several graphs have "no data"
3) the following graph wouldn't start with the correct value of _GET causing maybe problems?
New graph type Horizontal Bar requirement moved to #2828 for changelog clarity.
Percentage values in static graphs deferred to #2829
(In [5582]) * fixes #2706, #2828, #2704, refs #1721, #2637, #2711, #2318, #71 : horizontal static graph implemented
New FAQs concerning unicode support in ImageGraph :
(In [5736]) Refs #2704 svn clean up unused directories
see #3304 UX: Automatically download the unicode font when it is needed the first time.
I think this ticket is closed . please create new ticket for "horizontal and vertical bars should have a maximum width to avoid drawing huge bars when few of them are displayed " if necessary :) % was moved to #2829