Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access Control Plugin #2697

Closed
timo-bes opened this issue Oct 12, 2011 · 6 comments
Closed

Access Control Plugin #2697

timo-bes opened this issue Oct 12, 2011 · 6 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@timo-bes
Copy link
Member

Description

This plugin implements an access control layer for Piwik users. It makes sharing only parts of reports with different users possible. The restrictions are based on labels and metric names.

Implementation

There are only a few adjustments to core needed. The rest will be made available as a third party plugin.
@timo-bes
Copy link
Member Author

(In [5286]) refs #2697 parent reference can be archived with nested datatables

@timo-bes
Copy link
Member Author

(In [5287]) refs #2697 plugins can manipulate api output using the hook API.Proxy.processReturnValue

@timo-bes
Copy link
Member Author

In [5286], I also committed the new method DataTable::getEmptyClone. It's needed for another ticket I'm working on, but why not review now ;-)

Speaking of review, please have a look at the changes.

@mattab
Copy link
Member

mattab commented Oct 12, 2011

Looks good, however it's missing some unit tests in datatable.test.php - maybe one test function to check that all methods copying/creating tables have the parents array?

In [5287] what is the reasonning when testing for Piwik_*_API class name?

@mattab
Copy link
Member

mattab commented Dec 14, 2012

What happened to this plugin btw?

@mattab
Copy link
Member

mattab commented Jul 1, 2013

In bead696: Removing feature: enable_archive_parents_of_datatable = 0 (main reason: there is no test, second reason: there is no public plugin using this feature AFAIK)
@timo if you need this feature, let's put it back with some tests..
Refs #2697

@timo-bes timo-bes added this to the Future releases milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Removing feature: enable_archive_parents_of_datatable = 0 (main reaso…
bead696 
…n: there is no test, second reason: there is no public plugin using this feature AFAIK)

@timo if you need this feature, let's put it back with some tests..
 Refs matomo-org#2697
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timo-bes @mattab