Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions.getPageTitle and getPageUrl should work like other API methods with date=last30 #2662

Closed
mattab opened this issue Sep 16, 2011 · 4 comments
Closed

Actions.getPageTitle and getPageUrl should work like other API methods with date=last30 #2662

mattab opened this issue Sep 16, 2011 · 4 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
1.6

Comments

@mattab
Copy link
Member

mattab commented Sep 16, 2011

Currently it returns an error: http://demo.piwik.org/?module=API&method=Actions.getPageTitle&idSite=7&period=day&date=last30&format=html&token_auth=anonymous&pageName=Piwik%20Forums

We should patch the code so that the datatable accept to work with date=last30
@timo-bes
Copy link
Member

(In [5172]) Refs #2662 Actions.get* for date range

@mattab
Copy link
Member Author

mattab commented Sep 21, 2011

Code review:

  • excellent work!
  • test: all the last30 for getPageUrl etc. only had 0 visit days. Would you be able to add a test that shows results with data for the queried dates?

@mattab
Copy link
Member Author

mattab commented Sep 21, 2011

Note: for the tests, it will be pretty easy to add them, see example in this commit: http://dev.piwik.org/trac/changeset/5197#file2

@mattab
Copy link
Member Author

mattab commented Sep 27, 2011

(In [5235]) Fixes #2667

  • Stop aggregating visits for Custom variables of scope "page"
    • still OK for scope "visit" since there is supposed to be one custom var value per custom variable name for a given visit
  • Now we always display the Actions columns so that these rows with no visit still show the number of Actions
  • cleaned up from custom var output report, removed some "price_viewed" column left out

UI Change (future FAQ maybe...)

  • When there is a "Visits" column for the Custom Variable report with a value of "-" (hyphen) then it means this custom variable was used with scope=page.

Fixes #2662

  • Added integration tests testing getPageUrl with multiple periods and websites
  • fixed a bug when idSite=all or 1,2,3

@mattab mattab added this to the 1.6 Piwik 1.6 milestone Jul 8, 2014
@mattab mattab mentioned this issue Sep 27, 2011
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
1.6
Development

No branches or pull requests
2 participants
@timo-bes @mattab