@robocoder opened this Issue on August 2nd 2011 Contributor

#2594 was nagging at me all night.

I did a review of the code base, and there doesn't appear to be a reason why getCurrentSchema() couldn't return https when assume_secure_protocol = 1.

This would eliminate the special cases in the code. So, let's refactor and clean this up.

@robocoder commented on August 2nd 2011 Contributor

(In [5070]) fixes #2606, refs #2594

@mattab commented on August 10th 2011 Member

thanks for all the technical debt fixes.

Regarding this change,

  • can you please confirm that you tested to load https://server/piwik and all files were loading fine over https without triggering browser warning?
  • how much effort (hours) would it take to have a webtest testing to load the https version of piwik and verify that all links / ressources are https ?


@mattab commented on August 16th 2011 Member

reopening pending some QA questions above, vipsoft would you mind taking a quick look?

@robocoder commented on August 16th 2011 Contributor

There's no warning if you have a valid certificate (or accepted a self-signed one).

Webtest: The main stumbling blocks are going to be the jetty/jenkins environment, and how to reliably test ajax requests and dynamic content. (The latter already causes sporadic test failures.)

@mattab commented on August 16th 2011 Member

thanks for confirming

This Issue was closed on August 16th 2011
Powered by GitHub Issue Mirror