Matomo Issue #2534 - Charts - Top of chart cut off if data contains floats

@ziegenberg opened this Issue on July 2nd 2011 Contributor

In the Visitor Overview the Chart showing the actions per visit is cut off at the top.

I debugged through Chart.php and found the problem there. All the dates in [Chart.php Line 133](source:trunk/core/Visualization/Chart.php@4963#L133) are kind of floats with a comma as the decimal mark and the json_encode() three lines further creates rubbish as it takes the comma as a separator.

@ziegenberg commented on July 2nd 2011 Contributor

The comma as decimal mark is the same reason why the calculation in [getMaxValue()](source:trunk/core/Visualization/Chart.php@4963#L97) does not work.

@robocoder commented on July 2nd 2011 Contributor

Yeah, I suspected this just after committing [4963]. I'll revert and find the root cause.

@robocoder commented on July 3rd 2011 Contributor

(In [4967]) fixes #2534 (I think)...output looked ok with de_DE.UTF-8

@robocoder commented on July 3rd 2011 Contributor

[4967] fixed a bug in the json_encode compatibility function for floats

@ziegenberg commented on July 3rd 2011 Contributor

Patched my system. Works!

@vipsoft: Thanks for fixing this bug! I really appreciate your short response time.

@robocoder commented on July 3rd 2011 Contributor

Thanks for confirming.

This Issue was closed on July 3rd 2011

Charts - Top of chart cut off if data contains floats #2534