@anonymous-piwik-user opened this Issue on June 27th 2011

Index: Renderer.php


--- Renderer.php (rvision 4955)
+++ Renderer.php (copie de travail)
@@ -52,7 +52,10 @@
protected static function renderHeader()

  • @header('Content-Type: text/html; charset=utf-8');
  • if (!headers_sent())
  • {
  • header('Content-Type: text/html; charset=utf-8');
  •         }

Keywords: core DataTable Renderer.php

@anonymous-piwik-user commented on June 28th 2011


@robocoder commented on June 28th 2011 Contributor

Is this necessary? ErrorHandler checks if error_reporting() returns 0 (indicating the use of @).

Even so, what are you debugging that you needed this patch?

@anonymous-piwik-user commented on June 28th 2011

I record all types of errors, I made changes on my version, but instead of using the @ to hide the error, the patch will make it easier not to use it

@mattab commented on June 29th 2011 Member

There are many places we use silent fail @ and better not change just one, your error handler shouldd check for the silent fail instead

This Issue was closed on June 29th 2011
Powered by GitHub Issue Mirror