Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Config-Hook #2524

Closed
anonymous-matomo-user opened this issue Jun 27, 2011 · 6 comments
Closed

Enable Config-Hook #2524

anonymous-matomo-user opened this issue Jun 27, 2011 · 6 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. worksforme The issue cannot be reproduced and things work as intended.

Comments

@anonymous-matomo-user
Copy link

In our company we have global config-files, which are different on every developer-vm. therefor it would be nice, if there would be an
Zend_Registry::isRegistered('conf') in Piwik::createConfigObject before setting it. No great deal, but big effect ;)
Keywords: zend_config, isregistered

@anonymous-matomo-user
Copy link
Author

Actually I ment Zend_Registry::isRegistered('config')

@robocoder
Copy link
Contributor

createConfigObject() is called before plugins are loaded. How do you load your config?

@anonymous-matomo-user
Copy link
Author

Actually at the moment I'm loading the config how piwik it does by default. Therefor I think it would be best to check if 'config' is already in Zend_Registry, and, if so, not loading the piwik-config....

@mattab
Copy link
Member

mattab commented Jun 29, 2011

Please submit a patch for this feature to be considered :) we will reopen when a patch submitted, thanks!

@robocoder
Copy link
Contributor

Like I said, we load the config before plugins are loaded. Your plugin can certainly override it, but it looks like there's a chicken-and-egg problem adding a hook in core.

@anonymous-matomo-user
Copy link
Author

Well the problem is, that no plugin is loaded, if the database-configuration is not correct. Actually every developer has it's own mashine including mysql. Therefor it's necessary either to make plugins loaded before any database-connection is established, or, as I said, make it possible to set 'config'-registry-entry e.g. in bootstrap.php, which I can use since I saw it in index.php.

@anonymous-matomo-user anonymous-matomo-user added this to the Future releases milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Development

No branches or pull requests

3 participants